Description

@Param('id') id: number is not validated and accepts NaN as value in case of invalid id.

For example, if the following URL is accessed (http://example.com/users/asdf), instead of throwing an error, the id value is parsed to NaN. InvalidParamError(value, parameterName, parameterType) should be thrown instead.

The problem is due to how the checking of the result of the cast operation is done. NaN is not equal to NaN. Because of this it is necessary to use Number.isNaN().

Example

@JsonController('/users')
class UserController {

  @Get('/:id')
  get (@Param('id') id: number) {
    console.log(id);
  }
}

Result

GET http://example.com/users/1234 -> 1234
GET http://example.com/users/asdf -> NaN

Checklist

• the pull request title describes what this PR does (not a vague title like Update index.md)
• the pull request targets the default branch of the repository (develop)
• the code follows the established code style of the repository
  • npm run prettier:check passes
  • npm run lint:check passes
• tests are added for the changes I made (if any source code was modified)
• documentation added or updated
• I have run the project locally and verified that there are no errors

Fixes

fixes #348